pt-osc modified some comments

This commit is contained in:
frank-cizmich
2015-06-11 16:40:00 -03:00
parent 2e72b47e85
commit 703f803ae6
2 changed files with 25 additions and 7 deletions
+5 -3
View File
@@ -8562,10 +8562,12 @@ sub main {
# at /Users/daniel/p/pt-osc-2.1.1/lib/PerconaTest.pm line 559.
# ''
# doesn't match '(?-xism:Failed to find a unique new table name)'
#my $original_error = $EVAL_ERROR;
#
# (*) commented them for now because it caused infinite loop (frank)
# (*) Frank: commented them out because it caused infinite loop
# and the mentioned test error doesn't arise
#my $original_error = $EVAL_ERROR;
foreach my $task ( reverse @cleanup_tasks ) {
eval {
$task->();
+20 -4
View File
@@ -435,12 +435,28 @@ $sb->load_file('master', "$sample/bug-1340728_cleanup.sql");
# #############################################################################
# Issue p
#
# fails when no index is returned in EXPLAIN, even though --nocheck-plan is set
# (happens on HASH indexes)
# Issue LP 1446928
# Avoids an error trapping loop when --alter option contains an invalid
# statement.
# If this test fails it might lead to "segmentation fault" or "out of memory"
# #############################################################################
$output = output(
sub { pt_online_schema_change::main(@args, "$master_dsn,D=sakila,t=actor",
'--execute',
'--alter-foreign-keys-method=drop_swap',
'--alter', "GIBBERISH",
'--nocheck-plan',
),
},
stderr => 1,
);
like(
$output,
qr/Error altering new table/s,
"Bug 1446928: Avoid error trapping loop when --alter is invalid",
);
# #############################################################################
# Done.