From 6eba36898bbf80550a33c66c7a63ecab34c39cbb Mon Sep 17 00:00:00 2001 From: Baron Schwartz Date: Sun, 3 Jun 2012 22:09:37 -0400 Subject: [PATCH] fix some floating-point rendering problems --- t/pt-query-digest/review.t | 98 ++++++++++++++++++++++---------------- 1 file changed, 56 insertions(+), 42 deletions(-) diff --git a/t/pt-query-digest/review.t b/t/pt-query-digest/review.t index 1860d930..f0034426 100644 --- a/t/pt-query-digest/review.t +++ b/t/pt-query-digest/review.t @@ -79,68 +79,82 @@ is_deeply( ], 'Adds/updates queries to query review table' ); -$res = $dbh->selectall_arrayref('SELECT lock_time_median, lock_time_stddev, query_time_sum, checksum, rows_examined_stddev, ts_cnt, sample, rows_examined_median, rows_sent_min, rows_examined_min, rows_sent_sum, query_time_min, query_time_pct_95, rows_examined_sum, rows_sent_stddev, rows_sent_pct_95, query_time_max, rows_examined_max, query_time_stddev, rows_sent_median, lock_time_pct_95, ts_min, lock_time_min, lock_time_max, ts_max, rows_examined_pct_95 ,rows_sent_max, query_time_median, lock_time_sum FROM test.query_review_history', - { Slice => {} } ); + +$res = $dbh->selectall_arrayref('SELECT lock_time_median, lock_time_stddev, +FORMAT(query_time_sum, 6) AS query_time_sum, checksum, +FORMAT(rows_examined_stddev, 6) AS rows_examined_stddev, ts_cnt, sample, +FORMAT(rows_examined_median, 6) AS rows_examined_median, rows_sent_min, +rows_examined_min, rows_sent_sum, FORMAT(query_time_min, 6) AS query_time_min, +FORMAT(query_time_pct_95, 6) AS query_time_pct_95, rows_examined_sum, +FORMAT(rows_sent_stddev, 6) AS rows_sent_stddev, FORMAT(rows_sent_pct_95, 6) AS +rows_sent_pct_95, FORMAT(query_time_max, 6) AS query_time_max, +rows_examined_max, FORMAT(query_time_stddev, 6) AS query_time_stddev, +rows_sent_median, FORMAT(lock_time_pct_95, 6) AS lock_time_pct_95, ts_min, +FORMAT(lock_time_min, 6) AS lock_time_min, lock_time_max, ts_max, +FORMAT(rows_examined_pct_95, 6) AS rows_examined_pct_95, rows_sent_max, +FORMAT(query_time_median, 6) AS query_time_median, lock_time_sum FROM +test.query_review_history', { Slice => {} } ); + is_deeply( $res, [ { lock_time_median => '0', lock_time_stddev => '0', - query_time_sum => '3.6e-05', + query_time_sum => '0.000036', checksum => '11676753765851784517', - rows_examined_stddev => '0', + rows_examined_stddev => '0.000000', ts_cnt => '3', sample => 'SELECT col FROM foo_tbl', - rows_examined_median => '0', + rows_examined_median => '0.000000', rows_sent_min => '0', rows_examined_min => '0', rows_sent_sum => '0', - query_time_min => '1.2e-05', - query_time_pct_95 => '1.2e-05', + query_time_min => '0.000012', + query_time_pct_95 => '0.000012', rows_examined_sum => '0', - rows_sent_stddev => '0', - rows_sent_pct_95 => '0', - query_time_max => '1.2e-05', + rows_sent_stddev => '0.000000', + rows_sent_pct_95 => '0.000000', + query_time_max => '0.000012', rows_examined_max => '0', - query_time_stddev => '0', + query_time_stddev => '0.000000', rows_sent_median => '0', - lock_time_pct_95 => '0', + lock_time_pct_95 => '0.000000', ts_min => '2007-12-18 11:48:27', - lock_time_min => '0', + lock_time_min => '0.000000', lock_time_max => '0', ts_max => '2007-12-18 11:49:30', - rows_examined_pct_95 => '0', + rows_examined_pct_95 => '0.000000', rows_sent_max => '0', - query_time_median => '1.2e-05', + query_time_median => '0.000012', lock_time_sum => '0' }, { lock_time_median => '0', lock_time_stddev => '0', - query_time_sum => '3.6e-05', + query_time_sum => '0.000036', checksum => '15334040482108055940', - rows_examined_stddev => '0', + rows_examined_stddev => '0.000000', ts_cnt => '3', sample => 'SELECT col FROM bar_tbl', - rows_examined_median => '0', + rows_examined_median => '0.000000', rows_sent_min => '0', rows_examined_min => '0', rows_sent_sum => '0', - query_time_min => '1.2e-05', - query_time_pct_95 => '1.2e-05', + query_time_min => '0.000012', + query_time_pct_95 => '0.000012', rows_examined_sum => '0', - rows_sent_stddev => '0', - rows_sent_pct_95 => '0', - query_time_max => '1.2e-05', + rows_sent_stddev => '0.000000', + rows_sent_pct_95 => '0.000000', + query_time_max => '0.000012', rows_examined_max => '0', - query_time_stddev => '0', + query_time_stddev => '0.000000', rows_sent_median => '0', - lock_time_pct_95 => '0', + lock_time_pct_95 => '0.000000', ts_min => '2007-12-18 11:48:57', - lock_time_min => '0', + lock_time_min => '0.000000', lock_time_max => '0', ts_max => '2007-12-18 11:49:07', - rows_examined_pct_95 => '0', + rows_examined_pct_95 => '0.000000', rows_sent_max => '0', - query_time_median => '1.2e-05', + query_time_median => '0.000012', lock_time_sum => '0' } ], @@ -290,12 +304,12 @@ SET biz = '91848182522'", innodb_rec_lock_wait_min => 0, innodb_rec_lock_wait_pct_95 => 0, innodb_rec_lock_wait_stddev => 0, - lock_time_max => '2.7e-05', - lock_time_median => '2.7e-05', - lock_time_min => '2.7e-05', - lock_time_pct_95 => '2.7e-05', + lock_time_max => '0.000027', + lock_time_median => '0.000027', + lock_time_min => '0.000027', + lock_time_pct_95 => '0.000027', lock_time_stddev => '0', - lock_time_sum => '5.4e-05', + lock_time_sum => '0.000054', merge_passes_max => '0', merge_passes_median => '0', merge_passes_min => '0', @@ -304,12 +318,12 @@ SET biz = '91848182522'", merge_passes_sum => '0', qc_hit_cnt => '2', qc_hit_sum => '0', - query_time_max => 0.000530, - query_time_median => 0.000530, - query_time_min => 0.000530, - query_time_pct_95 => 0.000530, - query_time_stddev => 0, - query_time_sum => 0.000530 * 2, + query_time_max => '0.00053', + query_time_median => '0.00053', + query_time_min => '0.00053', + query_time_pct_95 => '0.00053', + query_time_stddev => '0', + query_time_sum => '0.00106', rows_affected_max => undef, rows_affected_median => undef, rows_affected_min => undef, @@ -317,10 +331,10 @@ SET biz = '91848182522'", rows_affected_stddev => undef, rows_affected_sum => undef, rows_examined_max => 0, - rows_examined_median => 0, + rows_examined_median => '0', rows_examined_min => 0, - rows_examined_pct_95 => 0, - rows_examined_stddev => 0, + rows_examined_pct_95 => '0', + rows_examined_stddev => '0', rows_examined_sum => 0, rows_read_max => undef, rows_read_median => undef,