percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-23 21:05:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Sandbox.pm: Make get_dbh_for die if it can't get a dbh, which should help to diagnose some test box failures

Browse Source
This commit is contained in:
Brian Fraser fraserb@gmail.com
2012-10-31 13:48:20 -03:00
parent d616a7e5e6
commit 6840ce638e
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Sandbox.pm
View File

@@ -118,8 +118,7 @@ sub get_dbh_for {
my $dbh;
eval { $dbh = $dp->get_dbh($dp->get_cxn_params($dsn), $cxn_ops) };
if ( $EVAL_ERROR ) {
PTDEBUG && _d('Failed to get dbh for', $server, ':', $EVAL_ERROR);
return 0;
die 'Failed to get dbh for' . $server . ': ' . $EVAL_ERROR;
}
$dbh->{InactiveDestroy} = 1; # Prevent destroying on fork.
$dbh->{FetchHashKeyName} = 'NAME_lc' unless $cxn_ops && $cxn_ops->{no_lc};
@@ -265,7 +264,7 @@ sub leftover_servers {
PTDEBUG && _d('Checking for leftover servers');
foreach my $serverno ( 1..6 ) {
my $server = "master$serverno";
my $dbh = $self->get_dbh_for($server);
my $dbh = eval { $self->get_dbh_for($server) };
if ( $dbh ) {
$dbh->disconnect();
return "Sandbox $server " . $port_for{$server} . " was left up.";