From 5eb857b7d30dde57b480bd62b40f80414964f23f Mon Sep 17 00:00:00 2001 From: Daniel Nichter Date: Sun, 11 Sep 2011 13:06:12 -0600 Subject: [PATCH] Warn about oversize chunks. Use while() instead of for() to iter works. Fix typo in warning message. --- bin/pt-table-checksum | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bin/pt-table-checksum b/bin/pt-table-checksum index e3aa10d4..bba29508 100755 --- a/bin/pt-table-checksum +++ b/bin/pt-table-checksum @@ -4913,6 +4913,7 @@ sub main { # First, check if the chunk is too large. if ( $o->get('chunk-size-limit') && is_oversize_chunk(%args, %common_modules) ) { + warn "Chunk $args{nibbleno} of table $tbl->{db}.$tbl->{tbl} is too large\n"; $tbl->{checksum_results}->{oversize_chunks}++; $tbl->{checksum_results}->{exit_status} |= 1; return 0; # next boundary @@ -4943,7 +4944,7 @@ sub main { ); TABLE: - foreach my $tbl ( $schema_iter->next_schema_object() ) { + while ( my $tbl = $schema_iter->next_schema_object() ) { use_repl_db( dbh => $dbh, tbl => $tbl, @@ -4974,7 +4975,7 @@ sub main { } }; if ($EVAL_ERROR) { - warn "Error checksumming $tbl->{db}.$tbl->{$tbl}: $EVAL_ERROR\n"; + warn "Error checksumming $tbl->{db}.$tbl->{tbl}: $EVAL_ERROR\n"; $tbl->{checksum_results}->{exit_status} |= 1; }