percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-10-19 17:04:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

sprintf rudundancy warnings

Browse Source
This commit is contained in:
frank-cizmich
2016-02-05 13:35:44 -03:00
parent baddc014e1
commit 56b44a7522
16 changed files with 83 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/QueryReportFormatter.pm
View File

@@ -123,9 +123,9 @@ sub BUILDARGS {
report_all => $o->get('report-all'),
report_histogram => $o->get('report-histogram'),
},
num_format => "# %-${label_width}s %3s %7s %7s %7s %7s %7s %7s %7s",
bool_format => "# %-${label_width}s %3d%% yes, %3d%% no",
string_format => "# %-${label_width}s %s",
num_format => '# %1$-'.$label_width.'s %2$3s %3$7s %4$7s %5$7s %6$7s %7$7s %8$7s %9$7s',
bool_format => '# %1$-'.$label_width.'s %2$3d%% yes, %3$3d%% no',
string_format => '# %1$-'.$label_width.'s %2$s',
hidden_attrib => { # Don't sort/print these attribs in the reports.
arg => 1, # They're usually handled specially, or not
fingerprint => 1, # printed at all.
@@ -673,7 +673,11 @@ sub event_report {
$val->{checksum},
$val->{pos_in_log},
);
$line .= ('_' x (LINE_LENGTH - length($line) + $self->label_width() - 12));
my $underscores = LINE_LENGTH - length($line) + $self->label_width() - 12;
if ( $underscores < 0 ) {
$underscores = 0;
}
$line .= ('_' x $underscores);
push @result, $line;
# Second line: reason why this class is being reported.