From 1a3f42acb1da7ca7964bed9e2a759db4502833d6 Mon Sep 17 00:00:00 2001 From: Sveta Smirnova Date: Tue, 26 Aug 2025 19:36:46 +0300 Subject: [PATCH 1/2] PT-1564 - Man page broken for pt-secure-collect - Removed non-working condition from Makefile.PL - Added working condition for creating MAN1PODS hash --- Makefile.PL | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index b820a48f..008e7766 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -12,21 +12,17 @@ MAKE_GOTOOLS WriteMakefile( NAME => 'Percona::Toolkit', VERSION => '3.7.0-2', - EXE_FILES => [ - map { - (my $name = $_) =~ s/^bin.//; - my $file_name = $_; - if ( ( $file_name !~ m/mongo/ ) || ( $file_name !~ m/pg/ ) || ( $file_name !~ m/pt-stalk/ ) || ( $file_name !~ m/pt-k8s/ ) ) { - $_; - } - } - ], + EXE_FILES => [ ], MAN1PODS => { 'docs/percona-toolkit.pod' => 'blib/man1/percona-toolkit.1p', map { (my $name = $_) =~ s/^bin.//; my $file_name = $_; - if ( ( $file_name !~ m/mongo/ ) || ( $file_name !~ m/pg/ ) || ( $file_name !~ m/pt-stalk/ ) || ( $file_name !~ m/pt-k8s/ ) ) { + if ( ( $file_name =~ m/mongo/ ) || ( $file_name =~ m/pg/ ) || ( $file_name =~ m/galera/ ) || ( $file_name =~ m/k8s/ ) || ( $file_name =~ m/secure/ ) ) { + # We have to put empty line here to avoid the MAN1PODS hash corruption + '' => '', + } + else { $_ => "blib/man1/$name.1p"; } } @@ -37,4 +33,4 @@ WriteMakefile( DBI => 1.46, DBD::mysql => 3.0000_0, }, -); \ No newline at end of file +); From fb1f5be3395f7e64c72767f80eeb261a8f214a5c Mon Sep 17 00:00:00 2001 From: Sveta Smirnova Date: Wed, 10 Sep 2025 18:20:44 +0300 Subject: [PATCH 2/2] Update Makefile.PL Co-authored-by: EvgeniyPatlan --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index 008e7766..e8de3905 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -18,7 +18,7 @@ WriteMakefile( map { (my $name = $_) =~ s/^bin.//; my $file_name = $_; - if ( ( $file_name =~ m/mongo/ ) || ( $file_name =~ m/pg/ ) || ( $file_name =~ m/galera/ ) || ( $file_name =~ m/k8s/ ) || ( $file_name =~ m/secure/ ) ) { +if ( $file_name =~ m/(mongo|pg|galera|k8s|secure)/ ) { # We have to put empty line here to avoid the MAN1PODS hash corruption '' => '', }