percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-08 07:29:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

PT-1919 drop-swap can drop triggers (#483)

Browse Source 
* PT-1919 drop-swap can drop triggers

* PT-1919 Update changelog
This commit is contained in:
Carlos Salguero
2021-03-05 11:32:03 -03:00
committed by GitHub
parent 9913690ebc
commit 4f78d5450c
5 changed files with 410 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
bin/pt-online-schema-change
View File

@@ -10134,7 +10134,7 @@ sub main {
}
if ( $o->get('preserve-triggers') ) {
if ( !$o->get('swap-tables') && $o->get('drop-new-table') ) {
if ( !$o->get('swap-tables') && $o->get('drop-new-table') && !$o->get('alter-foreign-keys-method') eq "drop-swap" ) {
print ts("Skipping triggers creation since --no-swap-tables was specified along with --drop-new-table\n");
} else {
print ts("Adding original triggers to new table.\n");
@@ -11218,8 +11218,12 @@ sub rebuild_constraints {
tries => $tries->{update_foreign_keys},
stats => $stats,
code => sub {
PTDEBUG && _d($sql);
PTDEBUG && _d("SET foreign_key_checks=0");
$cxn->dbh()->do("SET foreign_key_checks=0");
PTDEBUG && _d($sql);
$cxn->dbh()->do($sql);
PTDEBUG && _d("SET foreign_key_checks=1");
$cxn->dbh()->do("SET foreign_key_checks=1");
$stats->{rebuilt_constraint}++;
},
);
@@ -11403,6 +11407,15 @@ sub create_triggers {
suffix => 'ins', event => 'INSERT', time => 'AFTER', orig_triggers => [],
new_trigger_sql => $insert_trigger, new_trigger_name => "${prefix}_ins",
},
{
event => 'DELETE', time => 'BEFORE', orig_triggers => [],
},
{
event => 'UPDATE', time => 'BEFORE', orig_triggers => [],
},
{
event => 'INSERT', time => 'BEFORE', orig_triggers => [],
},
];
$cxn->connect();
@@ -11461,6 +11474,7 @@ sub create_triggers {
my @trigger_names;
foreach my $trigger_info ( @$triggers_info ) {
next if ! ($trigger_info->{new_trigger_sql}); ###FIXED PT-1919
if ($o->get('execute') && !$args{dont}) {
osc_retry(
Cxn => $cxn,