percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-10 21:19:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

corrected index choosing bug in NibbleHandler

Browse Source
This commit is contained in:
frank-cizmich
2016-04-29 07:23:42 -03:00
parent fcb3191aec
commit 47cc4225d8
3 changed files with 43 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
lib/NibbleIterator.pm
View File

@@ -503,23 +503,33 @@ sub _find_best_index {
my $tbl_struct = $tbl->{tbl_struct};
my $indexes = $tbl_struct->{keys};
my $best_index;
my $want_index = $args{chunk_index};
# check if the user defined index exists
# and declare it best_index if so
if ( $want_index ) {
PTDEBUG && _d('User wants to use index', $want_index);
if ( !exists $indexes->{$want_index} ) {
PTDEBUG && _d('Cannot use user index because it does not exist');
$want_index = undef;
} else {
$best_index = $want_index;
}
}
if ( !$want_index && $args{mysql_index} ) {
# if no user definded index or user defined index not valid
# consider mysql's preferred index a candidate
if ( !$best_index && !$want_index && $args{mysql_index} ) {
PTDEBUG && _d('MySQL wants to use index', $args{mysql_index});
$want_index = $args{mysql_index};
}
my $best_index;
my @possible_indexes;
if ( $want_index ) {
# if haven't got a valid user chosen index
# check if mysql's preferred index is unique, and if so
# consider it the best, otherwise include it with other candidates
if ( !$best_index && $want_index ) {
if ( $indexes->{$want_index}->{is_unique} ) {
PTDEBUG && _d('Will use wanted index');
$best_index = $want_index;
@@ -529,7 +539,9 @@ sub _find_best_index {
push @possible_indexes, $want_index;
}
}
else {
# still no best index? select amongst all candidates.
if (!$best_index) {
PTDEBUG && _d('Auto-selecting best index');
foreach my $index ( $tp->sort_indexes($tbl_struct) ) {
if ( $index eq 'PRIMARY' || $indexes->{$index}->{is_unique} ) {