percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-23 21:05:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Presume STATEMENT binlog format if < 5.1.5 and still check other slaves in case they're newer versions of MySQL.

Browse Source
This commit is contained in:
Daniel Nichter
2012-10-26 17:06:21 -06:00
parent 3d03a3a0dc
commit 45ae32ceb2
1 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
bin/pt-table-checksum
View File

@@ -8554,15 +8554,21 @@ sub main {
PTDEBUG && _d(scalar @$slaves, 'slaves found'); PTDEBUG && _d(scalar @$slaves, 'slaves found');
# https://bugs.launchpad.net/percona-toolkit/+bug/938068 # https://bugs.launchpad.net/percona-toolkit/+bug/938068
if ( $o->get('check-binlog-format') if ( $o->get('check-binlog-format') ) {
&& VersionParser->new($master_dbh) >= '5.1.5' ) { my $master_binlog = 'STATEMENT';
my ($master_binlog) = $master_dbh->selectrow_array( if ( VersionParser->new($master_dbh) >= '5.1.5' ) {
'SELECT @@binlog_format'); ($master_binlog) = $master_dbh->selectrow_array(
'SELECT @@binlog_format');
}
my $err = ''; my $err = '';
for my $slave_cxn (@$slaves) { for my $slave_cxn (@$slaves) {
next unless VersionParser->new($slave_cxn->dbh) >= '5.1.5'; my $slave_binlog = 'STATEMENT';
my ($slave_binlog) = $slave_cxn->dbh->selectrow_array( if ( VersionParser->new($slave_cxn->dbh) >= '5.1.5' ) {
'SELECT @@binlog_format'); ($slave_binlog) = $slave_cxn->dbh->selectrow_array(
'SELECT @@binlog_format');
}
if ( $master_binlog ne $slave_binlog ) { if ( $master_binlog ne $slave_binlog ) {
$err .= $master_cxn->name() . " has binlog_format " $err .= $master_cxn->name() . " has binlog_format "
. $master_binlog . " but replica " . $slave_cxn->name() . $master_binlog . " but replica " . $slave_cxn->name()