percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-16 16:23:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

VariableAdvisorRules: Check that log_bin is ON instead of doing log_bin ? 1 : 0

Browse Source
This commit is contained in:
Brian Fraser fraserb@gmail.com
2012-07-30 11:44:28 -03:00
parent 2f0812fb33
commit 43708d7b65
3 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bin/pt-variable-advisor
View File

@@ -3202,7 +3202,7 @@ sub get_rules {
code => sub {
my ( %args ) = @_;
return _var_eq($args{variables}->{expire_log_days}, 0)
&& $args{variables}->{log_bin} ? 1 : 0;
&& _var_seq($args{variables}->{log_bin}, "ON");
},
},
{
@@ -3235,7 +3235,7 @@ sub get_rules {
code => sub {
my ( %args ) = @_;
return _var_seq($args{variables}->{innodb_locks_unsafe_for_binlog},
"ON") && $args{variables}->{log_bin} ? 1 : 0;
"ON") && _var_seq($args{variables}->{log_bin}, "ON");
},
},
{
@@ -3243,7 +3243,7 @@ sub get_rules {
code => sub {
my ( %args ) = @_;
return _var_sneq($args{variables}->{innodb_support_xa}, "ON")
&& $args{variables}->{log_bin} ? 1 : 0;
&& _var_seq($args{variables}->{log_bin}, "ON");
},
},
{
@@ -3291,7 +3291,7 @@ sub get_rules {
code => sub {
my ( %args ) = @_;
return
$args{variables}->{log_bin}
_var_seq($args{variables}->{log_bin}, "ON")
&& ( _var_eq($args{variables}->{sync_binlog}, 0)
|| _var_gt($args{variables}->{sync_binlog}, 1)) ? 1 : 0;
},