percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-14 23:40:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed indirect object syntax from CompareResults.pm

Browse Source
This commit is contained in:
Brian Fraser
2011-12-23 00:09:07 -03:00
parent 47091424aa
commit 37e321ef65
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
lib/CompareResults.pm
View File

@@ -354,7 +354,7 @@ sub _compare_rows {
# it to the 3rd and subsequent events. # it to the 3rd and subsequent events.
my @event0_rows = @{ $event0->{results_sth}->fetchall_arrayref({}) }; my @event0_rows = @{ $event0->{results_sth}->fetchall_arrayref({}) };
$event0->{row_count} = scalar @event0_rows; $event0->{row_count} = scalar @event0_rows;
my $left = new MockSth(@event0_rows); my $left = MockSth->new(@event0_rows);
$left->{NAME} = [ @{$event0->{results_sth}->{NAME}} ]; $left->{NAME} = [ @{$event0->{results_sth}->{NAME}} ];
EVENT: EVENT:
@@ -368,7 +368,7 @@ sub _compare_rows {
# we gobble the remaining rows in that sth and print them to an outfile. # we gobble the remaining rows in that sth and print them to an outfile.
# This short circuits RowDiff::compare_sets() which is what we want to do. # This short circuits RowDiff::compare_sets() which is what we want to do.
my $no_diff = 1; # results are identical; this catches 0 row results my $no_diff = 1; # results are identical; this catches 0 row results
my $outfile = new Outfile(); my $outfile = Outfile->new();
my ($left_outfile, $right_outfile, $n_rows); my ($left_outfile, $right_outfile, $n_rows);
my $same_row = sub { my $same_row = sub {
$event->{row_count}++; # Keep track of this event's row_count. $event->{row_count}++; # Keep track of this event's row_count.
@@ -399,8 +399,8 @@ sub _compare_rows {
return; return;
}; };
my $rd = new RowDiff(dbh => $dbh); my $rd = RowDiff->new(dbh => $dbh);
my $mocksync = new MockSyncStream( my $mocksync = MockSyncStream->new(
query => $event0->{arg}, query => $event0->{arg},
cols => $res_struct->{cols}, cols => $res_struct->{cols},
same_row => $same_row, same_row => $same_row,
@@ -634,7 +634,7 @@ sub diff_rows {
}; };
}; };
my $rd = new RowDiff( my $rd = RowDiff->new(
dbh => $left_dbh, dbh => $left_dbh,
key_cmp => $key_cmp, key_cmp => $key_cmp,
same_row => $same_row, same_row => $same_row,
@@ -643,7 +643,7 @@ sub diff_rows {
done => $done, done => $done,
trf => $trf, trf => $trf,
); );
my $ch = new ChangeHandler( my $ch = ChangeHandler->new(
left_db => $db, left_db => $db,
left_tbl => 'mk_upgrade_left', left_tbl => 'mk_upgrade_left',
right_db => $db, right_db => $db,
@@ -863,7 +863,7 @@ sub _report_diff_checksums {
return unless keys %{$self->{diffs}->{checksums}}; return unless keys %{$self->{diffs}->{checksums}};
my $report = new ReportFormatter(); my $report = ReportFormatter->new();
$report->set_title('Checksum differences'); $report->set_title('Checksum differences');
$report->set_columns( $report->set_columns(
$args{query_id_col}, $args{query_id_col},
@@ -894,7 +894,7 @@ sub _report_diff_col_vals {
return unless keys %{$self->{diffs}->{col_vals}}; return unless keys %{$self->{diffs}->{col_vals}};
my $report = new ReportFormatter(); my $report = ReportFormatter->new();
$report->set_title('Column value differences'); $report->set_title('Column value differences');
$report->set_columns( $report->set_columns(
$args{query_id_col}, $args{query_id_col},
@@ -929,7 +929,7 @@ sub _report_diff_row_counts {
return unless keys %{$self->{diffs}->{row_counts}}; return unless keys %{$self->{diffs}->{row_counts}};
my $report = new ReportFormatter(); my $report = ReportFormatter->new();
$report->set_title('Row count differences'); $report->set_title('Row count differences');
$report->set_columns( $report->set_columns(
$args{query_id_col}, $args{query_id_col},