percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-27 07:54:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

merged pt-table-checksum-requires-recursion-when-working-with-and-XtraDB-Cluster-node-1373937

Browse Source
This commit is contained in:
Frank Cizmich
2014-11-06 19:14:35 -02:00
parent e60dbe14b5 3e3f8bd5a9
commit 31f0520f8c
2 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
bin/pt-table-checksum
View File

@@ -9363,9 +9363,11 @@ sub main {
if ( $cluster_name_for{$master_cxn} ) { if ( $cluster_name_for{$master_cxn} ) {
if ( !@$slaves ) { if ( !@$slaves ) {
die $master_cxn->name() . " is a cluster node but no other nodes " if ( ($o->get('recursion-method')->[0] || '') ne 'none' ) {
. "or regular replicas were found. Use --recursion-method=dsn " die $master_cxn->name() . " is a cluster node but no other nodes "
. "to specify the other nodes in the cluster.\n"; . "or regular replicas were found. Use --recursion-method=dsn "
. "to specify the other nodes in the cluster.\n";
}
} }
# Make sure the master and all node are in the same cluster. # Make sure the master and all node are in the same cluster.
@@ -12240,9 +12242,13 @@ DSNs are ordered by C<id>, but C<id> and C<parent_id> are otherwise ignored.
The C<dsn> column contains a replica DSN like it would be given on the command The C<dsn> column contains a replica DSN like it would be given on the command
line, for example: C<"h=replica_host,u=repl_user,p=repl_pass">. line, for example: C<"h=replica_host,u=repl_user,p=repl_pass">.
The C<none> method prevents the tool from connecting to any replicas. The C<none> method makes the tool ignore all slaves and cluster nodes. This
This effectively disables all the L<"REPLICA CHECKS"> because there will method is not recommended because it effectively disables the
not be any replicas to check. Therefore, this method is not recommended. L<"REPLICA CHECKS"> and no differences can be found. It is useful, however, if
you only need to write checksums on the master or a single cluster node. The
safer alternative is C<--no-replicate-check>: the tool finds replicas and
cluster nodes, performs the L<"REPLICA CHECKS">, but does not check for
differences. See L<"--[no]replicate-check">.
=item --replicate =item --replicate

13
t/pt-table-checksum/pxc.t
View File

@@ -81,6 +81,17 @@ like(
"Dies if no other nodes are found" "Dies if no other nodes are found"
); );
($output, $exit_status) = full_output(
sub { pt_table_checksum::main(@args, '--recursion-method', 'none') },
stderr => 1,
);
ok (
$output =~ qr/WARNING/i && !$exit_status,
"Warns but doesn't die if --recursion-method=none - issue #1373937"
);
for my $args ( for my $args (
["using recusion-method=dsn", '--recursion-method', "dsn=$node1_dsn,D=dsns,t=dsns"], ["using recusion-method=dsn", '--recursion-method', "dsn=$node1_dsn,D=dsns,t=dsns"],
["using recursion-method=cluster", '--recursion-method', 'cluster'] ["using recursion-method=cluster", '--recursion-method', 'cluster']
@@ -232,7 +243,7 @@ for my $args (
# Wait for the slave to apply the binlogs from node1 (its master). # Wait for the slave to apply the binlogs from node1 (its master).
# Then change it so it's not consistent. # Then change it so it's not consistent.
PerconaTest::wait_for_table($slave_dbh, 'test.t'); PerconaTest::wait_for_table($slave_dbh, 'test.t');
$sb->wait_for_slaves('cslave1'); $sb->wait_for_slaves(master => 'node1', slave => 'cslave1');
$slave_dbh->do("update test.t set c='zebra' where c='z'"); $slave_dbh->do("update test.t set c='zebra' where c='z'");
$output = output( $output = output(