percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-02 10:36:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

PT-1218: pt-stalk ominous open_tables function (#535)

Browse Source 
After discussion change only affects error message that is more user-friendly now.
I also added two tests that check how open_tables function works in both cases:
with number of open tables less tha 1000 and greater than 1000
This commit is contained in:
Sveta Smirnova
2022-03-22 15:33:05 +03:00
committed by GitHub
parent 40f179cf26
commit 22ed941238
3 changed files with 53 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
t/pt-stalk/pt-stalk.t
View File

@@ -623,6 +623,57 @@ is(
"If both options --mysql-only and --system-only are specified only essential collections are triggered"
);
# ###########################################################################
# Test if open tables are collected if number of open tables <= 1000
# ###########################################################################
cleanup();
$dbh->do('FLUSH TABLES');
$retval = system("$trunk/bin/pt-stalk --no-stalk --run-time 10 --sleep 2 --dest $dest --pid $pid_file --iterations 1 --prefix test -- --defaults-file=$cnf >$log_file 2>&1");
PerconaTest::wait_until(sub { !-f $pid_file });
$output = `head -n 1 $dest/test-opentables1`;
is(
$output,
"Database\tTable\tIn_use\tName_locked\n",
"If number of open tables is less or equal than 1000, the output of 'SHOW OPEN TABLES' is collected"
);
# ###########################################################################
# Test if open tables are not collected if number of open tables > 1000
# ###########################################################################
cleanup();
$retval = $dbh->do('FLUSH TABLES');
$retval = $dbh->do('CREATE DATABASE IF NOT EXISTS test_open_tables');
$retval = $dbh->do('SET @old_table_open_cache=@@global.table_open_cache, GLOBAL table_open_cache=1001*@@global.table_open_cache_instances');
for (my $i = 0; $i < 1002; $i++) {
$retval = $dbh->do("CREATE TABLE IF NOT EXISTS test_open_tables.t_$i(id int)");
$retval = $dbh->do("INSERT INTO test_open_tables.t_$i VALUES($i)");
}
$retval = system("$trunk/bin/pt-stalk --no-stalk --run-time=10 --dest $dest --pid $pid_file --iterations 1 --prefix test -- --defaults-file=$cnf >$log_file 2>&1");
PerconaTest::wait_until(sub { !-f $pid_file });
$output = `cat $dest/test-opentables1`;
like(
$output,
qr/Logging disabled due to having over 1000 tables open. Number of tables currently open/,
"If number of open tables is greater than 1000, the output of 'SHOW OPEN TABLES' is not collected"
);
$retval = $dbh->do('SET GLOBAL table_open_cache=@old_table_open_cache');
$retval = $dbh->do('DROP DATABASE test_open_tables');
# ###########################################################################
# Test report about performance schema transactions in MySQL 5.7+
# ###########################################################################