mirror of
https://github.com/percona/percona-toolkit.git
synced 2026-04-10 01:12:18 +08:00
PT-1528 pt-online-schema-change "Invalid utf8mb4 character string (#473)
* PT-1528 [WIP] Proposed solution * PT-1528 Ingore UTF8 warning
This commit is contained in:
Carlos Salguero
@@ -8387,6 +8387,7 @@ package pt_online_schema_change;
|
||||
|
||||
use strict;
|
||||
use warnings FATAL => 'all';
|
||||
use utf8;
|
||||
use English qw(-no_match_vars);
|
||||
|
||||
use Percona::Toolkit;
|
||||
@@ -8474,7 +8475,7 @@ sub main {
|
||||
@drop_trigger_sqls = ();
|
||||
@triggers_not_dropped = ();
|
||||
$dont_interrupt_now = 0;
|
||||
%ignore_code = (1592 => 1, 1062 => 1);
|
||||
%ignore_code = (1592 => 1, 1062 => 1, 1300 => 1);
|
||||
|
||||
my %stats = (
|
||||
INSERT => 0,
|
||||
|
||||
70
t/pt-online-schema-change/pt-1528.t
Normal file
70
t/pt-online-schema-change/pt-1528.t
Normal file
@@ -0,0 +1,70 @@
|
||||
#!/usr/bin/env perl
|
||||
|
||||
BEGIN {
|
||||
die "The PERCONA_TOOLKIT_BRANCH environment variable is not set.\n"
|
||||
unless $ENV{PERCONA_TOOLKIT_BRANCH} && -d $ENV{PERCONA_TOOLKIT_BRANCH};
|
||||
unshift @INC, "$ENV{PERCONA_TOOLKIT_BRANCH}/lib";
|
||||
};
|
||||
|
||||
use strict;
|
||||
use warnings FATAL => 'all';
|
||||
use threads;
|
||||
use threads::shared;
|
||||
use Thread::Semaphore;
|
||||
|
||||
use English qw(-no_match_vars);
|
||||
use Test::More;
|
||||
|
||||
use Data::Dumper;
|
||||
use PerconaTest;
|
||||
use Sandbox;
|
||||
use SqlModes;
|
||||
use File::Temp qw/ tempdir /;
|
||||
|
||||
if ($sandbox_version lt '5.7') {
|
||||
plan skip_all => 'This test needs MySQL 5.7+';
|
||||
} else {
|
||||
plan tests => 2;
|
||||
}
|
||||
|
||||
require "$trunk/bin/pt-online-schema-change";
|
||||
|
||||
my $dp = new DSNParser(opts=>$dsn_opts);
|
||||
my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp);
|
||||
|
||||
my $dbh = $sb->get_dbh_for('master');
|
||||
my $dsn = $sb->dsn_for("master");
|
||||
|
||||
# The sandbox servers run with lock_wait_timeout=3 and it's not dynamic
|
||||
# so we need to specify --set-vars innodb_lock_wait_timeout=3 else the
|
||||
# tool will die.
|
||||
my @args = (qw(--set-vars innodb_lock_wait_timeout=3));
|
||||
my $output;
|
||||
my $exit_status;
|
||||
|
||||
$sb->load_file('master', "t/pt-online-schema-change/samples/pt-1528.sql");
|
||||
|
||||
my $rows_before = $dbh->selectall_hashref("SELECT * FROM test.brokenutf8alter", "id");
|
||||
|
||||
($output, $exit_status) = full_output(
|
||||
sub { pt_online_schema_change::main(@args, "$dsn,D=test,t=brokenutf8alter",
|
||||
'--execute', '--charset=utf8', '--chunk-size', '2', '--alter', 'engine=innodb',
|
||||
),
|
||||
},
|
||||
stderr => 1,
|
||||
);
|
||||
|
||||
my $rows_after = $dbh->selectall_hashref("SELECT * FROM test.brokenutf8alter", "id");
|
||||
|
||||
is_deeply(
|
||||
$rows_before,
|
||||
$rows_after,
|
||||
"Should be equal",
|
||||
);
|
||||
|
||||
# #############################################################################
|
||||
# Done.
|
||||
# #############################################################################
|
||||
$sb->wipe_clean($dbh);
|
||||
ok($sb->ok(), "Sandbox servers") or BAIL_OUT(__FILE__ . " broke the sandbox");
|
||||
done_testing;
|
||||
68
t/pt-online-schema-change/samples/pt-1528.sql
Normal file
68
t/pt-online-schema-change/samples/pt-1528.sql
Normal file
@@ -0,0 +1,68 @@
|
||||
-- MySQL dump 10.13 Distrib 5.7.19-17, for debian-linux-gnu (x86_64)
|
||||
--
|
||||
-- Host: localhost Database: test
|
||||
-- ------------------------------------------------------
|
||||
-- Server version 5.7.19-17-log
|
||||
|
||||
/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
|
||||
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
|
||||
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
|
||||
/*!40101 SET NAMES utf8 */;
|
||||
/*!40103 SET @OLD_TIME_ZONE=@@TIME_ZONE */;
|
||||
/*!40103 SET TIME_ZONE='+00:00' */;
|
||||
/*!40014 SET @OLD_UNIQUE_CHECKS=@@UNIQUE_CHECKS, UNIQUE_CHECKS=0 */;
|
||||
/*!40014 SET @OLD_FOREIGN_KEY_CHECKS=@@FOREIGN_KEY_CHECKS, FOREIGN_KEY_CHECKS=0 */;
|
||||
/*!40101 SET @OLD_SQL_MODE=@@SQL_MODE, SQL_MODE='NO_AUTO_VALUE_ON_ZERO' */;
|
||||
/*!40111 SET @OLD_SQL_NOTES=@@SQL_NOTES, SQL_NOTES=0 */;
|
||||
/*!50717 SELECT COUNT(*) INTO @rocksdb_has_p_s_session_variables FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_SCHEMA = 'performance_schema' AND TABLE_NAME = 'session_variables' */;
|
||||
/*!50717 SET @rocksdb_get_is_supported = IF (@rocksdb_has_p_s_session_variables, 'SELECT COUNT(*) INTO @rocksdb_is_supported FROM performance_schema.session_variables WHERE VARIABLE_NAME=\'rocksdb_bulk_load\'', 'SELECT 0') */;
|
||||
/*!50717 PREPARE s FROM @rocksdb_get_is_supported */;
|
||||
/*!50717 EXECUTE s */;
|
||||
/*!50717 DEALLOCATE PREPARE s */;
|
||||
/*!50717 SET @rocksdb_enable_bulk_load = IF (@rocksdb_is_supported, 'SET SESSION rocksdb_bulk_load = 1', 'SET @rocksdb_dummy_bulk_load = 0') */;
|
||||
/*!50717 PREPARE s FROM @rocksdb_enable_bulk_load */;
|
||||
/*!50717 EXECUTE s */;
|
||||
/*!50717 DEALLOCATE PREPARE s */;
|
||||
|
||||
--
|
||||
-- Table structure for table `brokenutf8alter`
|
||||
--
|
||||
|
||||
DROP DATABASE IF EXISTS test;
|
||||
CREATE DATABASE test;
|
||||
|
||||
USE test;
|
||||
|
||||
DROP TABLE IF EXISTS `brokenutf8alter`;
|
||||
/*!40101 SET @saved_cs_client = @@character_set_client */;
|
||||
/*!40101 SET character_set_client = utf8 */;
|
||||
CREATE TABLE `brokenutf8alter` (
|
||||
`ID` binary(16) NOT NULL,
|
||||
PRIMARY KEY (`ID`)
|
||||
) ENGINE=InnoDB DEFAULT CHARSET=latin1;
|
||||
/*!40101 SET character_set_client = @saved_cs_client */;
|
||||
|
||||
--
|
||||
-- Dumping data for table `brokenutf8alter`
|
||||
--
|
||||
|
||||
LOCK TABLES `brokenutf8alter` WRITE;
|
||||
/*!40000 ALTER TABLE `brokenutf8alter` DISABLE KEYS */;
|
||||
INSERT INTO `brokenutf8alter` VALUES ('.SGõ:\èŠ\ßB¬\0'),('.SK,:\èŠ\ßB¬\0'),('.SL_:\èŠ\ßB¬\0'),('.SL\Ü:\èŠ\ßB¬\0'),('.SMB:\èŠ\ßB¬\0'),('.SM˜:\èŠ\ßB¬\0'),('.SMô:\èŠ\ßB¬\0'),('.SOE:\èŠ\ßB¬\0'),('.SO®:\èŠ\ßB¬\0'),('.SP:\èŠ\ßB¬\0'),('.SPZ:\èŠ\ßB¬\0'),('.SP°:\èŠ\ßB¬\0'),('.SQ:\èŠ\ßB¬\0'),('.SQX:\èŠ\ßB¬\0'),('.SQ©:\èŠ\ßB¬\0'),('.SQ÷:\èŠ\ßB¬\0'),('.SRK:\èŠ\ßB¬\0'),('.ST4:\èŠ\ßB¬\0'),('.SU=:\èŠ\ßB¬\0'),('.SU—:\èŠ\ßB¬\0'),('.SUð:\èŠ\ßB¬\0'),('.SVC:\èŠ\ßB¬\0'),('.SV”:\èŠ\ßB¬\0'),('.SV\å:\èŠ\ßB¬\0'),('.SW8:\èŠ\ßB¬\0'),('.SW‡:\èŠ\ßB¬\0'),('.SX\Ò:\èŠ\ßB¬\0'),('.SY\":\èŠ\ßB¬\0'),('.SYr:\èŠ\ßB¬\0'),('.SY\Â:\èŠ\ßB¬\0'),('.SZ:\èŠ\ßB¬\0'),('.SZ™:\èŠ\ßB¬\0'),('.S[):\èŠ\ßB¬\0'),('.S[º:\èŠ\ßB¬\0'),('.S\\N:\èŠ\ßB¬\0'),('.S\\\á:\èŠ\ßB¬\0'),('.S]>:\èŠ\ßB¬\0'),('.S]Ž:\èŠ\ßB¬\0'),('.S]\Þ:\èŠ\ßB¬\0'),('.S^.:\èŠ\ßB¬\0'),('.S^:\èŠ\ßB¬\0'),('.S^\Ë:\èŠ\ßB¬\0'),('.S_8:\èŠ\ßB¬\0'),('.S_À:\èŠ\ßB¬\0'),('.S`W:\èŠ\ßB¬\0'),('.S`ñ:\èŠ\ßB¬\0'),('.Sa~:\èŠ\ßB¬\0'),('.Sb:\èŠ\ßB¬\0'),('.Sb¨:\èŠ\ßB¬\0'),('.Sc>:\èŠ\ßB¬\0'),('.Sc\È:\èŠ\ßB¬\0'),('.Sd :\èŠ\ßB¬\0'),('.Sdv:\èŠ\ßB¬\0'),('.Sd\Ã:\èŠ\ßB¬\0'),('.Se:\èŠ\ßB¬\0'),('.Seb:\èŠ\ßB¬\0'),('.Se·:\èŠ\ßB¬\0'),('.Sf:\èŠ\ßB¬\0'),('.SfP:\èŠ\ßB¬\0'),('.SfŸ:\èŠ\ßB¬\0'),('.Sfñ:\èŠ\ßB¬\0'),('.Sg?:\èŠ\ßB¬\0'),('.Sg˜:\èŠ\ßB¬\0'),('.Sh:\èŠ\ßB¬\0'),('.Sh¨:\èŠ\ßB¬\0'),('.Si7:\èŠ\ßB¬\0'),('.Si\Ô:\èŠ\ßB¬\0'),('.Sji:\èŠ\ßB¬\0'),('.Sk:\èŠ\ßB¬\0'),('.Sk‰:\èŠ\ßB¬\0'),('.Sk\Ü:\èŠ\ßB¬\0'),('.Sl(:\èŠ\ßB¬\0'),('.Sl{:\èŠ\ßB¬\0'),('.Sl\É:\èŠ\ßB¬\0'),('.Sm\Z:\èŠ\ßB¬\0'),('.Smh:\èŠ\ßB¬\0'),('.Sm»:\èŠ\ßB¬\0'),('.Sn:\èŠ\ßB¬\0'),('.So:\èŠ\ßB¬\0'),('.Sob:\èŠ\ßB¬\0'),('.So´:\èŠ\ßB¬\0'),('.Sp:\èŠ\ßB¬\0'),('.SpQ:\èŠ\ßB¬\0'),('.Sp<53>:\èŠ\ßB¬\0'),('.Spð:\èŠ\ßB¬\0'),('.SqA:\èŠ\ßB¬\0'),('.Sq<53>:\èŠ\ßB¬\0'),('.Sq\Ü:\èŠ\ßB¬\0'),('.Sr+:\èŠ\ßB¬\0'),('.Srv:\èŠ\ßB¬\0'),('.SrÁ:\èŠ\ßB¬\0'),('.Ss:\èŠ\ßB¬\0'),('.Ss_:\èŠ\ßB¬\0'),('.St :\èŠ\ßB¬\0'),('.St :\èŠ\ßB¬\0'),('.St5:\èŠ\ßB¬\0'),('.StI:\èŠ\ßB¬\0'),('.St^:\èŠ\ßB¬\0'),('.Str:\èŠ\ßB¬\0'),('.StŠ:\èŠ\ßB¬\0'),('.StŸ:\èŠ\ßB¬\0');
|
||||
/*!40000 ALTER TABLE `brokenutf8alter` ENABLE KEYS */;
|
||||
UNLOCK TABLES;
|
||||
/*!50112 SET @disable_bulk_load = IF (@is_rocksdb_supported, 'SET SESSION rocksdb_bulk_load = @old_rocksdb_bulk_load', 'SET @dummy_rocksdb_bulk_load = 0') */;
|
||||
/*!50112 PREPARE s FROM @disable_bulk_load */;
|
||||
/*!50112 EXECUTE s */;
|
||||
/*!50112 DEALLOCATE PREPARE s */;
|
||||
/*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */;
|
||||
|
||||
/*!40101 SET SQL_MODE=@OLD_SQL_MODE */;
|
||||
/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */;
|
||||
/*!40014 SET UNIQUE_CHECKS=@OLD_UNIQUE_CHECKS */;
|
||||
/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
|
||||
/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
|
||||
/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;
|
||||
/*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */;
|
||||
|
||||
-- Dump completed on 2018-04-07 3:48:50
|
||||
Reference in New Issue
Block a user