percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-11 13:40:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix for 996069: Incorrect RES.001 when using aggregate functions

Browse Source
This commit is contained in:
Brian Fraser
2012-11-02 01:18:10 -03:00
parent 4b5c8969f0
commit 1aa154d6c6
3 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bin/pt-query-advisor
View File

@@ -3815,6 +3815,7 @@ sub get_rules {
return unless scalar %groupby_col; return unless scalar %groupby_col;
my $cols = [ my $cols = [
grep { _looks_like_column($_->{col}) } grep { _looks_like_column($_->{col}) }
grep { ! exists $_->{func} }
@{$event->{query_struct}->{columns}} @{$event->{query_struct}->{columns}}
]; ];
foreach my $col ( @$cols ) { foreach my $col ( @$cols ) {

1
lib/QueryAdvisorRules.pm
View File

@@ -344,6 +344,7 @@ sub get_rules {
# Skip non-columns -- NULL, digits, functions, variables # Skip non-columns -- NULL, digits, functions, variables
my $cols = [ my $cols = [
grep { _looks_like_column($_->{col}) } grep { _looks_like_column($_->{col}) }
grep { ! exists $_->{func} }
@{$event->{query_struct}->{columns}} @{$event->{query_struct}->{columns}}
]; ];
# All SELECT cols must be in GROUP BY cols clause. # All SELECT cols must be in GROUP BY cols clause.

5
t/lib/QueryAdvisorRules.t
View File

@@ -471,6 +471,11 @@ my @cases = (
query => q{select NULL, 1, COUNT(*), @@time_zone, foo as field2 from t1 group by field2}, query => q{select NULL, 1, COUNT(*), @@time_zone, foo as field2 from t1 group by field2},
advice => [qw(CLA.001)], advice => [qw(CLA.001)],
}, },
{
name => 'Bug 996069: wrong RES.001',
query => q{SELECT cola, MAX(colb) FROM table WHERE cola = 123 GROUP BY cola},
advice => [qw()],
},
); );
# Run the test cases. # Run the test cases.