percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-22 11:54:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't crash on empty tables with --chunk-size-limit=0. Don't crash trying to print MySQL warning. Finish updating (all the important) tests.

Browse Source
This commit is contained in:
Daniel Nichter
2011-10-15 17:47:56 -06:00
parent c28461aaef
commit 07420ff78e
8 changed files with 138 additions and 300 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
t/pt-table-checksum/oversize_chunks.t
View File

@@ -9,33 +9,45 @@ BEGIN {
use strict;
use warnings FATAL => 'all';
use English qw(-no_match_vars);
use Test::More;
use Test::More skip_all => 'Finish updating oversize_chunks.t';
use PerconaTest;
use Sandbox;
require "$trunk/bin/pt-table-checksum";
my $vp = new VersionParser();
my $dp = new DSNParser(opts=>$dsn_opts);
my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp);
my $dbh = $sb->get_dbh_for('master');
if ( !$dbh ) {
my $dp = new DSNParser(opts=>$dsn_opts);
my $sb = new Sandbox(basedir => '/tmp', DSNParser => $dp);
my $master_dbh = $sb->get_dbh_for('master');
if ( !$master_dbh ) {
plan skip_all => 'Cannot connect to sandbox master';
}
else {
plan tests => 3;
plan tests => 2;
}
# The sandbox servers run with lock_wait_timeout=3 and it's not dynamic
# so we need to specify --lock-wait-timeout=3 else the tool will die.
my $master_dsn = 'h=127.1,P=12345,u=msandbox,p=msandbox';
my @args = ($master_dsn, qw(--lock-wait-timeout 3));
my $row;
my $output;
my $cnf='/tmp/12345/my.sandbox.cnf';
my @args = ('-F', $cnf, 'h=127.1', qw(-t osc.t --chunk-size 10));
diag(`/tmp/12345/use < $trunk/t/pt-table-checksum/samples/oversize-chunks.sql`);
$sb->load_file('master', "t/pt-table-checksum/samples/oversize-chunks.sql");
# pt-table-checksum 2.0 isn't fooled as easily as 1.0 was. This
# test results in:
# Error checksumming table osc.t: Possible infinite loop detected!
# The lower boundary for chunk 2 is <13, 13> and the lower boundary
# for chunk 3 is also <13, 13>. This usually happens when using a
# non-unique single column index. The current chunk index for table
# osc.t is i which is not unique and covers 1 column.
ok(
no_diff(
sub { pt_table_checksum::main(@args) },
sub { pt_table_checksum::main(@args,
qw(-t osc.t --chunk-size 10)) },
"t/pt-table-checksum/samples/oversize-chunks.txt",
),
"Skip oversize chunk"
@@ -43,21 +55,15 @@ ok(
ok(
no_diff(
sub { pt_table_checksum::main(@args, qw(--chunk-size-limit 0)) },
sub { pt_table_checksum::main(@args,
qw(-t osc.t --chunk-size 10 --chunk-size-limit 0)) },
"t/pt-table-checksum/samples/oversize-chunks-allowed.txt"
),
"Allow oversize chunk"
);
$output = `$trunk/bin/pt-table-checksum -F $cnf h=127.1 --chunk-size-limit 0.999 --chunk-size 100 2>&1`;
like(
$output,
qr/chunk-size-limit must be >= 1 or 0 to disable/,
"Verify --chunk-size-limit size"
);
# #############################################################################
# Done.
# #############################################################################
$sb->wipe_clean($dbh);
$sb->wipe_clean($master_dbh);
exit;