From 048defdb50efadc7b428f079df4782cd46af52d0 Mon Sep 17 00:00:00 2001
From: amontecillo <amontecillo@marqeta.com>
Date: Wed, 12 Oct 2016 21:07:16 -0700
Subject: [PATCH] Simplified the new fk algo and renamed a variable

---
 bin/pt-online-schema-change | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/bin/pt-online-schema-change b/bin/pt-online-schema-change
index bf786d68..2cce5778 100755
--- a/bin/pt-online-schema-change
+++ b/bin/pt-online-schema-change
@@ -10103,12 +10103,12 @@ sub create_new_table {
       # Has no _, we add one to make 1
       # This gives on more salt where the FK names have been previously been altered
       # https://bugs.launchpad.net/percona-toolkit/+bug/1632522
-      my %search = (
+      my %search_dict = (
         'CONSTRAINT `__' => 'CONSTRAINT `',
         'CONSTRAINT `_' => 'CONSTRAINT `__',
         'CONSTRAINT `' => 'CONSTRAINT `_'
       );
-      $sql =~ s/((?^:CONSTRAINT `__|CONSTRAINT `_|CONSTRAINT `))/$search{$1}/gm;
+      $sql =~ s/((?^:CONSTRAINT `__|CONSTRAINT `_|CONSTRAINT `))/$search_dict{$1}/gm;
 
       if ( $o->get('default-engine') ) {
          $sql =~ s/\s+ENGINE=\S+//;
@@ -10485,9 +10485,7 @@ sub rebuild_constraints {
          # This will add 2 _ to a self referencing FK thus avoiding a duplicate key constraint
          # https://bugs.launchpad.net/percona-toolkit/+bug/1632522
          my $new_fk;
-         if ($fk =~ /^_/) {
-           ($new_fk = $fk) =~ s/^_/__/;
-         } elsif ($fk =~ /^__/) {
+         if ($fk =~ /^__/) {
            ($new_fk = $fk) =~ s/^__//;
          } else {
            $new_fk = '_'.$fk;