PT 2105 collect individual logs (#558)

* PT-2105 - Collect individual log files for PXC Combined log files are hard to read by humans. Since pt-k8-debug-collector is the tool that accesses data from the running pods, it can copy raw log files, necessary for troubleshooting PXC issues. So, in addition to collecting logs.txt, this adds method getIndividualFiles for the Dumper that reads individual files from PXC pods and stores them in the resulting archive. Additionally, this commit fixes invalid timestamps in the resulting archive. * PT-2105 - added support for non-default namespaces * PT-2105 Let pt-k8-debug-collector to collect individual logs in PXC pods Added test case for this new collection. * Update go.mod Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com> Co-authored-by: Viacheslav Sarzhan <slava.sarzhan@percona.com>
2025-09-18 09:43:09 +00:00 · 2022-11-17 19:32:19 +03:00
parent cf8f824d5e
commit 03ab27228f
6 changed files with 184 additions and 201 deletions
--- a/src/go/pt-k8s-debug-collector/main_test.go
+++ b/src/go/pt-k8s-debug-collector/main_test.go
@@ -0,0 +1,78 @@
+package main
+
+import (
+	"bytes"
+	"golang.org/x/exp/slices"
+	"os/exec"
+	"path"
+	"strings"
+	"testing"
+)
+
+/*
+Tests collection of the individual files by pt-k8s-debug-collector.
+Requires running K8SPXC instance and kubectl, configured to access that instance by default.
+*/
+func TestIndividualFiles(t *testing.T) {
+	tests := []struct {
+		name        string
+		cmd         []string
+		want        []string
+		preprocesor func(string) string
+	}{
+		{
+			// If the tool collects required log files
+			name: "pxc_logs_list",
+			// tar -tf cluster-dump-test.tar.gz --wildcards 'cluster-dump/*/var/lib/mysql/*'
+			cmd:  []string{"tar", "-tf", "cluster-dump.tar.gz", "--wildcards", "cluster-dump/*/var/lib/mysql/*"},
+			want: []string{"auto.cnf", "grastate.dat", "gvwstate.dat", "innobackup.backup.log", "innobackup.move.log", "innobackup.prepare.log", "mysqld-error.log", "mysqld.post.processing.log"},
+			preprocesor: func(in string) string {
+				files := strings.Split(in, "\n")
+				var result []string
+				for _, f := range files {
+					b := path.Base(f)
+					if !slices.Contains(result, b) && b != "." && b != "" {
+						result = append(result, b)
+					}
+				}
+				slices.Sort(result)
+				return strings.Join(result, "\n")
+			},
+		},
+		{
+			// If MySQL error log is not empty
+			name: "pxc_mysqld_error_log",
+			// tar --to-command="grep -m 1 -o Version:" -xzf cluster-dump-test.tar.gz --wildcards 'cluster-dump/*/var/lib/mysql/mysqld-error.log'
+			cmd:  []string{"tar", "--to-command", "grep -m 1 -o Version:", "-xzf", "cluster-dump.tar.gz", "--wildcards", "cluster-dump/*/var/lib/mysql/mysqld-error.log"},
+			want: []string{"Version:"},
+			preprocesor: func(in string) string {
+				nl := strings.Index(in, "\n")
+				if nl == -1 {
+					return ""
+				}
+				return in[:nl]
+			},
+		},
+	}
+
+	cmd := exec.Command("../../../bin/pt-k8s-debug-collector")
+	if err := cmd.Run(); err != nil {
+		t.Errorf("error executing pt-k8s-debug-collector: %s", err.Error())
+	}
+	defer func() {
+		cmd = exec.Command("rm", "-f", "cluster-dump.tar.gz")
+		if err := cmd.Run(); err != nil {
+			t.Errorf("error cleaning up test data: %s", err.Error())
+		}
+	}()
+
+	for _, test := range tests {
+		out, err := exec.Command(test.cmd[0], test.cmd[1:]...).CombinedOutput()
+		if err != nil {
+			t.Errorf("test %s, error running command %s:\n%s\n\nCommand output:\n%s", test.name, test.cmd[0], err.Error(), out)
+		}
+		if test.preprocesor(bytes.NewBuffer(out).String()) != strings.Join(test.want, "\n") {
+			t.Errorf("test %s, output is not as expected\nOutput: %s\nWanted: %s", test.name, test.preprocesor(bytes.NewBuffer(out).String()), test.want)
+		}
+	}
+}