percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2026-04-26 01:02:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix VariableAdvisorRules: test didn't pass mysql_version and rule didn't check if it's defined.

Browse Source
This commit is contained in:
Daniel Nichter
2013-08-08 08:35:19 -07:00
parent 2ec4a4328c
commit 02b5042b9b
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/VariableAdvisorRules.pm
+1
View File
@@ -215,6 +215,7 @@ sub get_rules {
code => sub { code => sub {
my ( %args ) = @_; my ( %args ) = @_;
my $mysql_version = $args{mysql_version}; my $mysql_version = $args{mysql_version};
return 0 unless $mysql_version;
return _var_lt($args{variables}->{innodb_max_dirty_pages_pct}, return _var_lt($args{variables}->{innodb_max_dirty_pages_pct},
($mysql_version < '5.5' ? 90 : 75)); ($mysql_version < '5.5' ? 90 : 75));
}, },
t/lib/VariableAdvisorRules.t
+1
View File
@@ -159,6 +159,7 @@ my @cases = (
}, },
{ name => "innodb_max_dirty_pages_pct", { name => "innodb_max_dirty_pages_pct",
vars => [qw(innodb_max_dirty_pages_pct 89)], vars => [qw(innodb_max_dirty_pages_pct 89)],
mysql_version => VersionParser->new('5.1.59'),
advice => [qw(innodb_max_dirty_pages_pct)], advice => [qw(innodb_max_dirty_pages_pct)],
}, },
{ name => "key_buffer_size", { name => "key_buffer_size",