percona/percona-toolkit
1
0
Fork 0
mirror of https://github.com/percona/percona-toolkit.git synced 2025-09-19 02:05:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Implemented Pingback::time_to_check()

Browse Source
This commit is contained in:
Brian Fraser fraserb@gmail.com
2012-08-21 16:50:12 -03:00
parent e9fc764e02
commit 01937e6d9f
2 changed files with 77 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
lib/Pingback.pm
View File

@@ -28,8 +28,11 @@ use English qw(-no_match_vars);
use constant PTDEBUG => $ENV{PTDEBUG} || 0;
use File::Basename ();
use Data::Dumper ();
use File::Basename qw();
use Data::Dumper qw();
use Fcntl qw(:DEFAULT);
use File::Spec;
sub Dumper {
local $Data::Dumper::Indent = 1;
@@ -124,6 +127,42 @@ sub pingback {
return \@suggestions;
}
my $one_day = 60 * 60 * 24;
sub time_to_check {
my ($file) = @_;
if ( !$file ) {
my $dir = File::Spec->tmpdir();
$file = File::Spec->catfile($dir, 'percona-toolkit-version-check');
}
my $mtime = (stat $file)[9];
# If there isn't an mtime, the file (probably) doesn't exist, so
# touch it and return true.
if ( !defined $mtime ) {
_touch($file);
return 1;
}
# Otherwise, if there's been more than a day since the last check,
# update the file and return true.
my $time = int(time());
if ( ($time - $mtime) > $one_day ) {
_touch($file);
return 1;
}
# Otherwise, we're still within the day, so don't do the version check.
return;
}
sub _touch {
my ($file) = @_;
sysopen my $fh, $file, O_WRONLY|O_CREAT|O_NONBLOCK
or die "Cannot create $file : $!";
close $fh or die "Cannot close $file : $!";
}
sub encode_client_response {
my (%args) = @_;
my @required_args = qw(items versions);

36
t/lib/Pingback.t
View File

@@ -179,6 +179,42 @@ SKIP: {
);
}
# #############################################################################
# Testing time_to_check
# #############################################################################
my $dir = File::Spec->tmpdir();
my $file = File::Spec->catfile($dir, 'percona-toolkit-version-check-test');
unlink $file;
ok(
Pingback::time_to_check($file),
"time_to_check() returns true if the file doesn't exist",
);
ok(
!Pingback::time_to_check($file),
"...but false if it exists and it's been less than 24 hours",
);
my $one_day = 60 * 60 * 24;
my ($old_atime, $old_mtime) = (stat($file))[8,9];
utime($old_atime - $one_day * 2, $old_mtime - $one_day * 2, $file);
cmp_ok(
(stat($file))[9],
q{<},
time() - $one_day,
"Sanity check, the file's mtime is now at least one day behind time()",
);
ok(
Pingback::time_to_check($file),
"time_to_check returns true if the file exists and it's mtime is at least one day old",
);
# #############################################################################
# Done.
# #############################################################################