node/nvm-windows
1
0
Fork 0
mirror of https://github.com/coreybutler/nvm-windows.git synced 2025-09-03 11:15:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
518 Commits 18 Branches 23 Tags
12c9aa350ea0c8e6ece409f27da179a20be151c7
Commit Graph

518 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Corey Butler
7af9934eaf Add error messages for failed version lookups (when nodejs.org returns partial/no results. Resolves #1064. 1.1.12 2023-11-22 10:41:38 -06:00
dependabot[bot]
770cc28139 Bump golang.org/x/sys in /buildtools/iconize 
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20201018230417-eeed37f84f13 to 0.1.0.
- [Commits](https://github.com/golang/sys/commits/v0.1.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
 2023-11-07 18:23:20 +00:00
Corey Butler
4854ee0832 Merge branch 'master' of github.com:coreybutler/nvm-windows 2023-11-07 12:22:49 -06:00
Corey Butler
3c736ab164 Add debugging option to identify IPv6 configurations and remind users it is slow. 2023-11-07 12:22:12 -06:00
Corey Butler
4b31ca31e1 Merge pull request #967 from nineninesevenfour/fix-spaces-build-bat 
allow to run build.bat on paths with spaces
 2023-10-10 17:21:00 +00:00
Corey Butler
9c37af6290 Merge pull request #965 from nineninesevenfour/fix-932-path-with-spaces 
fix issue #932
 2023-10-10 17:19:34 +00:00
Corey Butler
a73ef54a42 Merge pull request #1049 from Juneezee/master 
Avoid unnecessary byte/string conversion
 2023-10-10 17:14:26 +00:00
Eng Zer Jun
683357f2f3 Avoid unnecessary byte/string conversion 
We can use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` to avoid unnecessary `[]byte`
conversions and reduce allocations.

Example benchmark:

func BenchmarkMatch(b *testing.B) {
	reg, _ := regexp.Compile("[^0-9]")

	for i := 0; i < b.N; i++ {
		if match := reg.Match([]byte("v")); !match {
			b.Fail()
		}
	}
}

func BenchmarkMatchString(b *testing.B) {
	reg, _ := regexp.Compile("[^0-9]")

	for i := 0; i < b.N; i++ {
		if match := reg.MatchString("v"); !match {
			b.Fail()
		}
	}
}

BenchmarkMatch-16          	19712776	        65.47 ns/op	       1 B/op	       1 allocs/op
BenchmarkMatchString-16    	24261463	        51.16 ns/op	       0 B/op	       0 allocs/op

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
 2023-10-10 18:53:32 +08:00
Corey Butler
71713ecc75 Merge pull request #1048 from acdvorak/patch-1 
Fix small typo in README.md
 2023-10-09 18:07:53 +00:00
Andrew C. Dvorak
90b67e0ec1 Fix small typo in README.md 
`installter` → `installer`
 2023-10-09 10:23:23 -05:00
Corey Butler
27bd0d0def Update README.md 
closes #1044
 2023-10-06 13:22:43 -05:00
Corey Butler
e0e573a710 Merge pull request #1042 from coreybutler/coreybutler-patch-7 
Update bug_report.yml
 2023-10-02 17:26:21 +00:00
Corey Butler
34f5f135ae Update bug_report.yml 2023-10-02 12:26:11 -05:00
Corey Butler
d7c80b285b Update bug_report.yml 2023-10-02 12:25:44 -05:00
Corey Butler
511644513b Merge pull request #1041 from coreybutler/coreybutler-patch-6 
Update bug_report.yml
 2023-10-02 17:24:39 +00:00
Corey Butler
4d76e3077a Update bug_report.yml 2023-10-02 12:24:23 -05:00
Corey Butler
27e38b2a17 Merge pull request #1040 from coreybutler/coreybutler-patch-5 
Update bug_report.yml
 2023-10-02 17:23:26 +00:00
Corey Butler
e2458b1827 Update bug_report.yml 2023-10-02 12:22:56 -05:00
Corey Butler
df8ca9eb89 Merge pull request #1032 from Humbunklung/master 
Modified folder detection code against #1031
 2023-09-20 12:43:50 -05:00
Corey Butler
504c540c82 Merge pull request #1034 from coreybutler/coreybutler-patch-4 
Update README.md
 2023-09-19 22:59:08 -05:00
Corey Butler
cdc945d736 Update README.md 2023-09-19 22:58:28 -05:00
Shengyuan Ye
53283980d5 Modified folder detection code against #1031 2023-09-20 09:49:57 +08:00
Corey Butler
7591688f32 Merge pull request #1016 from sitiom/winget-releaser 
Change Winget Releaser job to `ubuntu-latest`
 2023-09-18 04:17:24 -05:00
sitiom
2ef52e672b Change Winget Releaser job to ubuntu-latest 2023-08-17 14:58:13 +08:00
Corey Butler
c2aba37b1e Merge pull request #1005 from coreybutler/coreybutler-patch-3 
Update README.md
 2023-07-11 10:10:52 -05:00
Corey Butler
4abbd31782 Update README.md 2023-07-11 10:10:03 -05:00
Corey Butler
c1a633745c prevent invalid zip file from exracting files to arbitrary locations. 2023-04-27 11:31:01 -05:00
Corey Butler
be690ad162 Add instructions for determining the version. 2023-04-22 11:11:27 -05:00
Corey Butler
11eb58e96c Remove email address so people don't feel required to post their address publically (this was optional, but some treat it as required) 2023-04-22 11:07:44 -05:00
Corey Butler
e0670513e9 Add nvm debug output placeholder for issues 2023-04-22 11:02:17 -05:00
Corey Butler
0990c1fa75 Added a debug check to identify invalid Node installations. 2023-04-20 09:44:15 -05:00
Corey Butler
026d2de590 Remove redundant security section 2023-04-19 09:22:47 -05:00
Corey Butler
692c70e5b8 Add link for questions 2023-04-19 09:21:58 -05:00
Corey Butler
1ee174444f Add link for questions 2023-04-19 09:21:01 -05:00
Corey Butler
18f1313317 Feature template updates 2023-04-19 09:14:29 -05:00
Corey Butler
9e0925a135 Bug template updates 2023-04-19 09:10:20 -05:00
Corey Butler
0c80da1792 Bug template updates 2023-04-19 09:07:54 -05:00
Corey Butler
49a622921f Added question about shell 2023-04-19 09:02:09 -05:00
Corey Butler
571fd9596e Add shell output formatting 2023-04-19 08:56:44 -05:00
Corey Butler
6232216e30 Add template for feature requests 2023-04-19 08:52:22 -05:00
Corey Butler
47527d89d1 Updating bug submission template 2023-04-19 08:35:58 -05:00
Corey Butler
2eeba20fdf Updating bug submission template 2023-04-19 08:34:36 -05:00
Corey Butler
1f21d64b43 Updating bug submission template 2023-04-19 08:32:34 -05:00
Corey Butler
9bae64209e Merge branch 'master' of github.com:coreybutler/nvm-windows 2023-04-19 08:26:35 -05:00
Corey Butler
49818a2c20 Update bug report 2023-04-19 08:26:21 -05:00
Corey Butler
9682d1ac45 Version bump 2023-04-19 08:26:05 -05:00
Harald Fassler
2dad26dff4 allow to run build.bat on paths with spaces 
Signed-off-by: Harald Fassler <harald.fassler+9974@gmail.com>
 2023-04-16 11:16:17 +02:00
Harald Fassler
6c175fabaf fix issue #932 
Signed-off-by: Harald Fassler <harald.fassler+9974@gmail.com>
 2023-04-15 12:36:21 +02:00
Corey Butler
ee314da0ab Merge pull request #963 from Tester798/fix-symlink-detect 
Fix symlink detect if it points to nothing
 2023-04-13 21:45:25 +00:00
Tester798
11625ec131 Fix symlink detect if it points to nothing 2023-04-13 15:25:59 +03:00