Fix review comments

This commit is contained in:
1ilit 2025-05-11 21:34:20 +04:00
parent a1c60af3cd
commit cd4befcda3
5 changed files with 8 additions and 24 deletions

View File

@ -507,7 +507,7 @@ export default function Canvas() {
}
setDragging({
element: ObjectType.NONE,
id: -1,
id: null,
prevX: 0,
prevY: 0,
initialPositions: [],
@ -589,7 +589,7 @@ export default function Canvas() {
setPanning((old) => ({ ...old, isPanning: false }));
setDragging({
element: ObjectType.NONE,
id: -1,
id: null,
prevX: 0,
prevY: 0,
initialPositions: [],

View File

@ -145,7 +145,6 @@ export default function ControlPanel({
}
}
setRedoStack((prev) => [...prev, a]);
console.log(a);
return;
}
@ -660,7 +659,6 @@ export default function ControlPanel({
const paste = () => {
navigator.clipboard.readText().then((text) => {
let obj = null;
console.log(text);
try {
obj = JSON.parse(text);
} catch (error) {
@ -1148,16 +1146,14 @@ export default function ControlPanel({
setRedoStack([]);
if (!diagramId) {
console.error("Something went wrong.");
Toast.error(t("oops_smth_went_wrong"));
return;
}
db.table("diagrams")
.delete(diagramId)
.then(() => {
console.info("Deleted diagram successfully.");
})
.catch((error) => {
Toast.error(t("oops_smth_went_wrong"));
console.error(
`Error deleting records with gistId '${diagramId}':`,
error,

View File

@ -65,7 +65,7 @@ export function toDBML(diagram) {
(f) => f.id === rel.endFieldId,
);
`Ref ${rel.name} {\n\t${startTableName}.${startFieldName} ${cardinality(rel)} ${endTableName}.${endFieldName} [ delete: ${rel.deleteConstraint.toLowerCase()}, update: ${rel.updateConstraint.toLowerCase()} ]\n}`;
return `Ref ${rel.name} {\n\t${startTableName}.${startFieldName} ${cardinality(rel)} ${endTableName}.${endFieldName} [ delete: ${rel.deleteConstraint.toLowerCase()}, update: ${rel.updateConstraint.toLowerCase()} ]\n}`;
};
return `${diagram.enums

View File

@ -80,7 +80,6 @@ export function fromOracleSQL(ast, diagramDb = DB.GENERIC) {
table.fields.push(field);
} else if (d.resource === "constraint") {
const relationship = {};
const startTableId = table.id;
const startFieldName = d.constraint.columns[0];
const endFieldName = d.constraint.reference.columns[0];
const endTableName = d.constraint.reference.object.name;
@ -98,7 +97,7 @@ export function fromOracleSQL(ast, diagramDb = DB.GENERIC) {
);
if (!startField) return;
relationship.startTableId = startTableId;
relationship.startTableId = table.id;
relationship.startFieldId = startField.id;
relationship.endTableId = endTable.id;
relationship.endFieldId = endField.id;
@ -106,12 +105,7 @@ export function fromOracleSQL(ast, diagramDb = DB.GENERIC) {
relationship.name =
d.name && Boolean(d.name.trim())
? d.name
: "fk_" +
table.name +
"_" +
startFieldName +
"_" +
endTableName;
: `fk_${table.name}_${startFieldName}_${endTableName}`;
relationship.deleteConstraint =
d.constraint.reference.on_delete &&
Boolean(d.constraint.reference.on_delete.trim())

View File

@ -137,13 +137,7 @@ export function fromPostgres(ast, diagramDb = DB.GENERIC) {
const startField = table.find((f) => f.name === startFieldName);
if (!startField) return;
relationship.name =
"fk_" +
startTableName +
"_" +
startFieldName +
"_" +
endTableName;
relationship.name = `fk_${startTableName}_${startFieldName}_${endTableName}`;
relationship.startTableId = startTableId;
relationship.endTableId = endTable.id;
relationship.endFieldId = endField.id;