drawdb-io/drawdb
1
0
Fork 0
mirror of https://github.com/drawdb-io/drawdb.git synced 2025-05-24 02:09:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix review comments

Browse Source
This commit is contained in:
1ilit 2025-05-11 21:34:20 +04:00
parent a1c60af3cd
commit cd4befcda3
5 changed files with 8 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/components/EditorCanvas/Canvas.jsx
View File

@ -507,7 +507,7 @@ export default function Canvas() {
} }
setDragging({ setDragging({
element: ObjectType.NONE, element: ObjectType.NONE,
id: -1, id: null,
prevX: 0, prevX: 0,
prevY: 0, prevY: 0,
initialPositions: [], initialPositions: [],
@ -589,7 +589,7 @@ export default function Canvas() {
setPanning((old) => ({ ...old, isPanning: false })); setPanning((old) => ({ ...old, isPanning: false }));
setDragging({ setDragging({
element: ObjectType.NONE, element: ObjectType.NONE,
id: -1, id: null,
prevX: 0, prevX: 0,
prevY: 0, prevY: 0,
initialPositions: [], initialPositions: [],

8
src/components/EditorHeader/ControlPanel.jsx
View File

@ -145,7 +145,6 @@ export default function ControlPanel({
} }
} }
setRedoStack((prev) => [...prev, a]); setRedoStack((prev) => [...prev, a]);
console.log(a);
return; return;
} }
@ -660,7 +659,6 @@ export default function ControlPanel({
const paste = () => { const paste = () => {
navigator.clipboard.readText().then((text) => { navigator.clipboard.readText().then((text) => {
let obj = null; let obj = null;
console.log(text);
try { try {
obj = JSON.parse(text); obj = JSON.parse(text);
} catch (error) { } catch (error) {
@ -1148,16 +1146,14 @@ export default function ControlPanel({
setRedoStack([]); setRedoStack([]);
if (!diagramId) { if (!diagramId) {
console.error("Something went wrong."); Toast.error(t("oops_smth_went_wrong"));
return; return;
} }
db.table("diagrams") db.table("diagrams")
.delete(diagramId) .delete(diagramId)
.then(() => {
console.info("Deleted diagram successfully.");
})
.catch((error) => { .catch((error) => {
Toast.error(t("oops_smth_went_wrong"));
console.error( console.error(
`Error deleting records with gistId '${diagramId}':`, `Error deleting records with gistId '${diagramId}':`,
error, error,

2
src/utils/exportAs/dbml.js
View File

@ -65,7 +65,7 @@ export function toDBML(diagram) {
(f) => f.id === rel.endFieldId, (f) => f.id === rel.endFieldId,
); );
`Ref ${rel.name} {\n\t${startTableName}.${startFieldName} ${cardinality(rel)} ${endTableName}.${endFieldName} [ delete: ${rel.deleteConstraint.toLowerCase()}, update: ${rel.updateConstraint.toLowerCase()} ]\n}`; return `Ref ${rel.name} {\n\t${startTableName}.${startFieldName} ${cardinality(rel)} ${endTableName}.${endFieldName} [ delete: ${rel.deleteConstraint.toLowerCase()}, update: ${rel.updateConstraint.toLowerCase()} ]\n}`;
}; };
return `${diagram.enums return `${diagram.enums

10
src/utils/importSQL/oraclesql.js
View File

@ -80,7 +80,6 @@ export function fromOracleSQL(ast, diagramDb = DB.GENERIC) {
table.fields.push(field); table.fields.push(field);
} else if (d.resource === "constraint") { } else if (d.resource === "constraint") {
const relationship = {}; const relationship = {};
const startTableId = table.id;
const startFieldName = d.constraint.columns[0]; const startFieldName = d.constraint.columns[0];
const endFieldName = d.constraint.reference.columns[0]; const endFieldName = d.constraint.reference.columns[0];
const endTableName = d.constraint.reference.object.name; const endTableName = d.constraint.reference.object.name;
@ -98,7 +97,7 @@ export function fromOracleSQL(ast, diagramDb = DB.GENERIC) {
); );
if (!startField) return; if (!startField) return;
relationship.startTableId = startTableId; relationship.startTableId = table.id;
relationship.startFieldId = startField.id; relationship.startFieldId = startField.id;
relationship.endTableId = endTable.id; relationship.endTableId = endTable.id;
relationship.endFieldId = endField.id; relationship.endFieldId = endField.id;
@ -106,12 +105,7 @@ export function fromOracleSQL(ast, diagramDb = DB.GENERIC) {
relationship.name = relationship.name =
d.name && Boolean(d.name.trim()) d.name && Boolean(d.name.trim())
? d.name ? d.name
: "fk_" + : `fk_${table.name}_${startFieldName}_${endTableName}`;
table.name +
"_" +
startFieldName +
"_" +
endTableName;
relationship.deleteConstraint = relationship.deleteConstraint =
d.constraint.reference.on_delete && d.constraint.reference.on_delete &&
Boolean(d.constraint.reference.on_delete.trim()) Boolean(d.constraint.reference.on_delete.trim())

8
src/utils/importSQL/postgres.js
View File

@ -137,13 +137,7 @@ export function fromPostgres(ast, diagramDb = DB.GENERIC) {
const startField = table.find((f) => f.name === startFieldName); const startField = table.find((f) => f.name === startFieldName);
if (!startField) return; if (!startField) return;
relationship.name = relationship.name = `fk_${startTableName}_${startFieldName}_${endTableName}`;
"fk_" +
startTableName +
"_" +
startFieldName +
"_" +
endTableName;
relationship.startTableId = startTableId; relationship.startTableId = startTableId;
relationship.endTableId = endTable.id; relationship.endTableId = endTable.id;
relationship.endFieldId = endField.id; relationship.endFieldId = endField.id;