mirror of
https://github.com/apache/maven-mvnd.git
synced 2025-10-13 21:50:48 +00:00
b6bddf2ceb
Some checks failed
Early Access / Default build (without GraalVM) (push) Has been cancelled
Early Access / Build with GraalVM on macos-13 (push) Has been cancelled
Early Access / Build with GraalVM on macos-latest (push) Has been cancelled
Early Access / Build with GraalVM on ubuntu-latest (push) Has been cancelled
Early Access / Build with GraalVM on windows-latest (push) Has been cancelled
Early Access / Site build (push) Has been cancelled
Stale / stale (push) Has been cancelled
The daemon was implementing the legacy plexus.interactivity Prompter interface, which Maven 4 no longer calls. Instead, it needs to implement the new maven.api Prompter interface. This also simplifies the code, since the legacy prompter handling is now done by Maven core and it delegates to the new interface if an old plugin uses it. Also, prompting was skipped on dumb terminals for some reason. This meant that prompting could not be tested with automated tests using ProcessBuilder. It also meant that piping input into mvnd on the terminal wouldn't work. This made it inconsistent with regular Maven, which supports promting on a dumb terminal. I've reactivated it, which makes the prompting integration tests for our Maven extension pass again. There was also a missing console flush before sending the response to the daemon, which could lead to inconsistent output, where the newline was sometimes printed before and sometimes after the next line from the daemon. Fixes #1292