The JvmTestClient pushed things to system properties and then did not clean up them. This went invisible, as long as user did not have user-wide extensions like smart-builder that suddenly was not filtered out anymore from tested mvnd daemon and caused havoc.
Changes:
* def client helper method emits "prev state" for properties it altered
* JvmTestClient uses this map to restore properties
* MavenConfIgnore ITs modified to still ignore takari smart builder as well...
Fixes#1357
Seems MSC fork does not allow pushes from users who have commit rights on forked maven-mvnd, so am incorporating @ascheman changes here as well.
This PR is:
* fixes from PR https://github.com/apache/maven-mvnd/pull/1252
* plus fix SO isse (self injected cache)
* plus migrated whole daemon to Maven DI (from javax.inject) except those that override Sisu components
* ported latest Maven changes
Experiment PR to figure out why MacOS GH runners keep failing with transport related (SSL handshake abort, HTTP timeouts) errors. As we know linux and windows boxes are in Azure, while macos boxes are somewhere else, and we get regularly real strange errors like "SSL handshake errors", "HTTP timeout error (against Central?)", so suspicion is on JDK transport (in HTTP/2 mode).
Experiments:
* force apache transport (HTTP/1.1) - ✔️
* force JDK transport into HTTP/1.1 - 🟥
* use big timeout for connectTimeout - ✔️
Conclusion: for ITs we will for now increase the default (10sec) `connectTimeout` Resolver configuration, as it seems too low.
Changes:
* no source change
* (build) expel all versions from child modules: they must be all top level depMgmt or pluginMgmt
* (build) Top POM contains GAVs while child modules GA+scope. This tremendously simplifies maintenance.
* (javadoc) fix Javadoc errors
* (build) remove obsolete profiles and mr-JARs, project is 17+
Updates:
* maven wrapper 3.3.2 w/ scripts
Most of cumulative things dependabot reported, plus more.
Changes:
* use plugins from parent (instead to double-maintain them here as well)
* general cleanup, add property where there are 2+ uses for it
* update plugins not present in parent
* non-key dependencies (maven3, maven4, graalvm not touched) updates
Port Maven 3.9.7 config and new properties (session.root/top)
into Daemon m39.
The IT got this property as it triggers exception (failure)
if mvn39 could not "discover" top directory.
Fixes#910
* Add configuration to send build scans to https://ge.apache.org
* Add `.mvn` directories to IT tests projects that lack one
Some of the integration tests to do not have `.mvn` directories and
search up the project structure until they find the `.mvn` directory
of the root project.
This change adds `.mvn` directories with empty `maven.config` files so
that the sample projects in VCS will be as close as possible to those
executed during integration testing
* Make the default (non-native) build work again
* the renamed test is supposed to use the native binary, but it was
being picked up by surefire, because of its name. For non-native builds
(e.g. without -Pnative) the test would fail as the native
binary does not exist
* Add GitHub job for for default (non-native) build