apache/maven-mvnd
1
0
Fork 0
mirror of https://github.com/apache/maven-mvnd.git synced 2026-01-13 07:04:14 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Support short variants of boolean properties #279

Browse Source
This commit is contained in:
Peter Palaga
2020-12-21 16:07:00 +01:00
parent 87e6712992
commit fc2c4076a7
3 changed files with 16 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java
View File

@@ -596,7 +596,8 @@ public class DaemonParameters {
}
public boolean asBoolean() {
return Boolean.parseBoolean(get());
final String val = get();
return "".equals(val) || Boolean.parseBoolean(val);
}
public int asInt() {

10
client/src/test/java/org/mvndaemon/mvnd/client/EnvironmentTest.java
View File

@@ -24,6 +24,8 @@ import java.util.Map;
import java.util.Properties;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import org.mvndaemon.mvnd.client.DaemonParameters.EnvValue;
import org.mvndaemon.mvnd.client.DaemonParameters.ValueSource;
import org.mvndaemon.mvnd.common.Environment;
import static org.junit.jupiter.api.Assertions.assertEquals;
@@ -119,6 +121,14 @@ public class EnvironmentTest {
assertEquals("C:\\jdk-11.0.2\\", Environment.cygpath("/cygdrive/c/jdk-11.0.2/"));
}
@Test
void emptyBooleanEnvValueIsTrue() {
final String EMPTY_STRING = "";
final EnvValue envVal = new EnvValue(Environment.MVND_NO_BUFERING,
new ValueSource(sb -> sb.append("envValueAsBoolean"), () -> EMPTY_STRING));
assertEquals(true, envVal.asBoolean());
}
static class EnvironmentResource implements AutoCloseable {
private final Properties props = new Properties();