alibaba/p3c
1
0
Fork 0
mirror of https://github.com/alibaba/p3c.git synced 2025-10-15 07:32:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #153 from LQZYC/master

Browse Source 
fix issue #68
support package name like ali88.ps.service
This commit is contained in:
SeanCai
2017-10-31 20:42:52 -05:00
committed by GitHub
parent 40bcf5441a 8a2cd82a73
commit db90432a25
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/naming/PackageNamingRule.java
View File

@@ -30,7 +30,7 @@ import net.sourceforge.pmd.lang.ast.Node;
*/ */
public class PackageNamingRule extends AbstractXpathRule { public class PackageNamingRule extends AbstractXpathRule {
private static final String XPATH = "//PackageDeclaration/Name\n" private static final String XPATH = "//PackageDeclaration/Name\n"
+ "[not (matches(@Image, '^[a-z]+(\\.[a-z][a-z0-9]*)*$'))]"; + "[not (matches(@Image, '^[a-z0-9]+(\\.[a-z][a-z0-9]*)*$'))]";
public PackageNamingRule() { public PackageNamingRule() {
setXPath(XPATH); setXPath(XPATH);

14
p3c-pmd/src/test/resources/com/alibaba/p3c/pmd/lang/java/rule/naming/xml/PackageNamingRule.xml
View File

@@ -31,5 +31,19 @@
</test-code> </test-code>
<code-fragment id="PackageNamingRule2">
<![CDATA[
package ali88.ps.service;
public class SomeClass {
}
]]>
</code-fragment>
<test-code>
<description>Package Name should be lowercase</description>
<expected-problems>0</expected-problems>
<code-ref id="PackageNamingRule2" />
</test-code>
</test-data> </test-data>