alibaba/p3c
1
0
Fork 0
mirror of https://github.com/alibaba/p3c.git synced 2025-10-14 23:21:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

transactional check pattern for rollbackFor or rollbakOn

Browse Source
This commit is contained in:
骏烈
2017-11-28 17:29:58 +08:00
parent 30445436ab
commit 84e5982e30
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
p3c-pmd/src/main/java/com/alibaba/p3c/pmd/lang/java/rule/exception/TransactionMustHaveRollbackRule.java
View File

@@ -37,7 +37,7 @@ public class TransactionMustHaveRollbackRule extends AbstractAliRule {
private static final String TRANSACTIONAL_ANNOTATION_NAME = "Transactional";
private static final String TRANSACTIONAL_FULL_NAME = "org.springframework.transaction.annotation."
+ TRANSACTIONAL_ANNOTATION_NAME;
private static final String ROLLBACK_FOR = "rollbackFor";
private static final String ROLLBACK_PREFIX = "rollback";
private static final String XPATH_FOR_ROLLBACK = "//StatementExpression/PrimaryExpression"
+ "/PrimaryPrefix/Name[ends-with(@Image,'rollback')]";
@@ -82,7 +82,7 @@ public class TransactionMustHaveRollbackRule extends AbstractAliRule {
private boolean rollbackAttrSet(List<ASTMemberValuePair> memberValuePairList) {
for (ASTMemberValuePair pair : memberValuePairList) {
if (ROLLBACK_FOR.equals(pair.getImage())) {
if (pair.getImage() != null && pair.getImage().startsWith(ROLLBACK_PREFIX)) {
return true;
}
}