fix same tag in different datasets (#4673) (#4680)

Co-authored-by: heheer <heheer@sealos.io>

docSite/content/zh-cn/docs/development/upgrading/497.md

@@ -38,4 +38,5 @@ weight: 793
 8. 调试知识库检索模块，提示无权操作知识库。
 9. 文本内容提取节点，默认值赋值逻辑。
 10. 分享链接中，会强制返回嵌套应用中的引用内容。
+11. 知识库集合元数据过滤时，不同知识库的同名标签使用 $and 筛选无法获取结果。
 

packages/service/core/dataset/search/controller.ts

@@ -291,50 +291,64 @@ export async function searchDatasetData(
           ? collectionFilterMatch
           : json5.parse(collectionFilterMatch);
 
-      // Tag
+      const andTags = jsonMatch?.tags?.$and as (string | null)[] | undefined;
-      let andTags = jsonMatch?.tags?.$and as (string | null)[] | undefined;
+      const orTags = jsonMatch?.tags?.$or as (string | null)[] | undefined;
-      let orTags = jsonMatch?.tags?.$or as (string | null)[] | undefined;
 
-      // get andTagIds
       if (andTags && andTags.length > 0) {
-        // tag 去重
+        const uniqueAndTags = Array.from(new Set(andTags));
-        andTags = Array.from(new Set(andTags));
+        if (uniqueAndTags.includes(null) && uniqueAndTags.some((tag) => typeof tag === 'string')) {
-
-        if (andTags.includes(null) && andTags.some((tag) => typeof tag === 'string')) {
           return [];
         }
-
+        if (uniqueAndTags.every((tag) => typeof tag === 'string')) {
-        if (andTags.every((tag) => typeof tag === 'string')) {
+          const matchedTags = await MongoDatasetCollectionTags.find(
-          // Get tagId by tag string
-          const andTagIdList = await MongoDatasetCollectionTags.find(
             {
               teamId,
               datasetId: { $in: datasetIds },
-              tag: { $in: andTags }
+              tag: { $in: uniqueAndTags as string[] }
             },
-            '_id',
+            '_id datasetId tag',
-            {
+            { ...readFromSecondary }
-              ...readFromSecondary
-            }
           ).lean();
 
-          // If you enter a tag that does not exist, none will be found
+          // Group tags by dataset
-          if (andTagIdList.length !== andTags.length) return [];
+          const datasetTagMap = new Map<string, { tagIds: string[]; tagNames: Set<string> }>();
 
-          // Get collectionId by tagId
+          matchedTags.forEach((tag) => {
-          const collections = await MongoDatasetCollection.find(
+            const datasetId = String(tag.datasetId);
-            {
+            if (!datasetTagMap.has(datasetId)) {
-              teamId,
+              datasetTagMap.set(datasetId, {
-              datasetId: { $in: datasetIds },
+                tagIds: [],
-              tags: { $all: andTagIdList.map((item) => String(item._id)) }
+                tagNames: new Set()
-            },
+              });
-            '_id',
-            {
-              ...readFromSecondary
             }
-          ).lean();
+
-          tagCollectionIdList = collections.map((item) => String(item._id));
+            const datasetData = datasetTagMap.get(datasetId)!;
-        } else if (andTags.every((tag) => tag === null)) {
+            datasetData.tagIds.push(String(tag._id));
+            datasetData.tagNames.add(tag.tag);
+          });
+
+          const validDatasetIds = Array.from(datasetTagMap.entries())
+            .filter(([_, data]) => uniqueAndTags.every((tag) => data.tagNames.has(tag as string)))
+            .map(([datasetId]) => datasetId);
+
+          if (validDatasetIds.length === 0) return [];
+
+          const collectionsPromises = validDatasetIds.map((datasetId) => {
+            const { tagIds } = datasetTagMap.get(datasetId)!;
+            return MongoDatasetCollection.find(
+              {
+                teamId,
+                datasetId,
+                tags: { $all: tagIds }
+              },
+              '_id',
+              { ...readFromSecondary }
+            ).lean();
+          });
+
+          const collectionsResults = await Promise.all(collectionsPromises);
+          tagCollectionIdList = collectionsResults.flat().map((item) => String(item._id));
+        } else if (uniqueAndTags.every((tag) => tag === null)) {
           const collections = await MongoDatasetCollection.find(
             {
               teamId,
@@ -342,9 +356,7 @@ export async function searchDatasetData(
               $or: [{ tags: { $size: 0 } }, { tags: { $exists: false } }]
             },
             '_id',
-            {
+            { ...readFromSecondary }
-              ...readFromSecondary
-            }
           ).lean();
           tagCollectionIdList = collections.map((item) => String(item._id));
         }