From 2dc6b760a3a4b2d93287ef494e4666bc73651032 Mon Sep 17 00:00:00 2001
From: heheer <heheer@sealos.io>
Date: Sat, 28 Sep 2024 18:00:22 +0800
Subject: [PATCH] perf: change tool params type label & enum input conditional
 rendering (#2835)

---
 .../NodeToolParams/ToolParamsEditModal.tsx    | 36 ++++++++++++-------
 .../web/core/workflow/constants/dataType.ts   |  6 ++--
 2 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/projects/app/src/pages/app/detail/components/WorkflowComponents/Flow/nodes/NodeToolParams/ToolParamsEditModal.tsx b/projects/app/src/pages/app/detail/components/WorkflowComponents/Flow/nodes/NodeToolParams/ToolParamsEditModal.tsx
index 801d13d5c..2ad5e5d29 100644
--- a/projects/app/src/pages/app/detail/components/WorkflowComponents/Flow/nodes/NodeToolParams/ToolParamsEditModal.tsx
+++ b/projects/app/src/pages/app/detail/components/WorkflowComponents/Flow/nodes/NodeToolParams/ToolParamsEditModal.tsx
@@ -3,7 +3,7 @@ import { Box, Button, Flex, Input, ModalBody, ModalFooter, Textarea } from '@cha
 import { FlowNodeInputItemType } from '@fastgpt/global/core/workflow/type/io';
 import MyModal from '@fastgpt/web/components/common/MyModal';
 import MySelect from '@fastgpt/web/components/common/MySelect';
-import React, { useCallback } from 'react';
+import React, { useCallback, useMemo } from 'react';
 import { useForm } from 'react-hook-form';
 import { useTranslation } from 'react-i18next';
 import { defaultEditFormData } from '../render/RenderToolInput/EditFieldModal';
@@ -14,6 +14,7 @@ import { useToast } from '@fastgpt/web/hooks/useToast';
 import { FlowNodeOutputTypeEnum } from '@fastgpt/global/core/workflow/node/constant';
 import FormLabel from '@fastgpt/web/components/common/MyBox/FormLabel';
 import QuestionTip from '@fastgpt/web/components/common/MyTooltip/QuestionTip';
+import { WorkflowIOValueTypeEnum } from '@fastgpt/global/core/workflow/constants';
 
 const ToolParamsEditModal = ({
   defaultValue = defaultEditFormData,
@@ -106,6 +107,13 @@ const ToolParamsEditModal = ({
     [toast]
   );
 
+  const showEnumInput = useMemo(() => {
+    return !(
+      valueType === WorkflowIOValueTypeEnum.boolean ||
+      valueType === WorkflowIOValueTypeEnum.arrayBoolean
+    );
+  }, [valueType]);
+
   return (
     <MyModal isOpen iconSrc="modal/edit" title={t('workflow:tool_field')} onClose={onClose}>
       <ModalBody>
@@ -135,7 +143,7 @@ const ToolParamsEditModal = ({
             placeholder={t('workflow:tool_params.params_name_placeholder')}
           />
         </Flex>
-        <Flex alignItems={'center'} mb={5}>
+        <Flex alignItems={'center'} mb={showEnumInput ? 5 : 0}>
           <FormLabel flex={'0 0 80px'}>{t('workflow:tool_params.params_description')}</FormLabel>
           <Input
             bg={'myGray.50'}
@@ -145,17 +153,19 @@ const ToolParamsEditModal = ({
             placeholder={t('workflow:tool_params.params_description_placeholder')}
           />
         </Flex>
-        <Box>
-          <Flex alignItems={'center'} mb={2}>
-            <FormLabel>{t('workflow:tool_params.enum_values')}</FormLabel>
-            <QuestionTip label={t('workflow:tool_params.enum_values_tip')} />
-          </Flex>
-          <Textarea
-            bg={'myGray.50'}
-            {...register('enum')}
-            placeholder={t('workflow:tool_params.enum_placeholder')}
-          />
-        </Box>
+        {showEnumInput && (
+          <Box>
+            <Flex alignItems={'center'} mb={2}>
+              <FormLabel>{t('workflow:tool_params.enum_values')}</FormLabel>
+              <QuestionTip label={t('workflow:tool_params.enum_values_tip')} />
+            </Flex>
+            <Textarea
+              bg={'myGray.50'}
+              {...register('enum')}
+              placeholder={t('workflow:tool_params.enum_placeholder')}
+            />
+          </Box>
+        )}
       </ModalBody>
       <ModalFooter>
         <Button variant={'whiteBase'} mr={2} onClick={onClose}>
diff --git a/projects/app/src/web/core/workflow/constants/dataType.ts b/projects/app/src/web/core/workflow/constants/dataType.ts
index 5362bfcf6..9ffa05896 100644
--- a/projects/app/src/web/core/workflow/constants/dataType.ts
+++ b/projects/app/src/web/core/workflow/constants/dataType.ts
@@ -14,15 +14,15 @@ export const fnValueTypeSelect = [
     value: WorkflowIOValueTypeEnum.boolean
   },
   {
-    label: WorkflowIOValueTypeEnum.arrayString,
+    label: 'array<string>',
     value: WorkflowIOValueTypeEnum.arrayString
   },
   {
-    label: WorkflowIOValueTypeEnum.arrayNumber,
+    label: 'array<number>',
     value: WorkflowIOValueTypeEnum.arrayNumber
   },
   {
-    label: WorkflowIOValueTypeEnum.arrayBoolean,
+    label: 'array<boolean>',
     value: WorkflowIOValueTypeEnum.arrayBoolean
   }
 ];